Skip to content

Revert "Preserve the .debug_gdb_scripts section" #145014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

Revert "Preserve the .debug_gdb_scripts section" #145014

merged 2 commits into from
Aug 7, 2025

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Aug 6, 2025

#143679 introduces a significant build time perf regression for ripgrep. Let's revert it such that we can investigate it without pressure.

@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2025

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@bjorn3 bjorn3 mentioned this pull request Aug 6, 2025
Merged
@bjorn3
Copy link
Member Author

bjorn3 commented Aug 6, 2025

cc @sebastianpoeplau

@lqd
Copy link
Member

lqd commented Aug 6, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 6, 2025

📌 Commit e02cc40 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2025
@lqd
Copy link
Member

lqd commented Aug 6, 2025

BTW for future reverts, you can revert the merge commit itself instead of each individual commit.

@bjorn3
Copy link
Member Author

bjorn3 commented Aug 6, 2025

git revert gave an error when I tried to revert the merge commit.

@lqd
Copy link
Member

lqd commented Aug 6, 2025

Indeed, you need to use git revert -m 1.

@jieyouxu jieyouxu assigned lqd and unassigned jieyouxu Aug 7, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 7, 2025
@Zalathar
Rollup merge of rust-lang#145014 - bjorn3:revert_preserve_debug_gdb_s…
79e429a 
…cripts, r=lqd

Revert "Preserve the .debug_gdb_scripts section"

rust-lang#143679 introduces a significant build time perf regression for ripgrep. Let's revert it such that we can investigate it without pressure.
@Zalathar Zalathar mentioned this pull request Aug 7, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 7, 2025
@Zalathar
Rollup merge of rust-lang#145014 - bjorn3:revert_preserve_debug_gdb_s…
a2974c3 
…cripts, r=lqd

Revert "Preserve the .debug_gdb_scripts section"

rust-lang#143679 introduces a significant build time perf regression for ripgrep. Let's revert it such that we can investigate it without pressure.
@Zalathar Zalathar mentioned this pull request Aug 7, 2025
Closed
bors added a commit that referenced this pull request Aug 7, 2025
@bors
Auto merge of #145039 - Zalathar:rollup-98v9fbg, r=Zalathar
5f76d77 
Rollup of 20 pull requests

Successful merges:

 - #137831 (Tweak auto trait errors)
 - #143028 (emit `StorageLive` and schedule `StorageDead` for `let`-`else`'s bindings after matching)
 - #143764 (lower pattern bindings in the order they're written and base drop order on primary bindings' order)
 - #143808 (Port `#[should_panic]` to the new attribute parsing infrastructure )
 - #143906 (Miri: non-deterministic floating point operations in `foreign_items`)
 - #143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps)
 - #144133 (Stabilize const TypeId::of)
 - #144439 (Introduce ModernIdent type to unify macro 2.0 hygiene handling)
 - #144473 (Address libunwind.a inconsistency issues in the bootstrap program)
 - #144659 (bootstrap: refactor mingw dist and fix gnullvm)
 - #144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
 - #144807 (Streamline config in bootstrap)
 - #144900 (Stabilize `unsigned_signed_diff` feature)
 - #144903 (Rename `begin_panic_handler` to `panic_handler`)
 - #144931 ([win][arm64ec] Fix msvc-wholearchive for Arm64EC)
 - #144974 (compiler-builtins subtree update)
 - #144997 (bump bootstrap compiler to 1.90 beta)
 - #145004 (Couple of minor cleanups)
 - #145009 (A couple small changes for rust-analyzer next-solver work)
 - #145014 (Revert "Preserve the .debug_gdb_scripts section")

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar
Copy link
Contributor

Zalathar commented Aug 7, 2025

Per #145039 (comment), let's not roll this up, since it has known perf impact.

@bors rollup=never p=6

@bors
Copy link
Collaborator

bors commented Aug 7, 2025

⌛ Testing commit e02cc40 with merge 9b1a30e...

@bors
Copy link
Collaborator

bors commented Aug 7, 2025

☀️ Test successful - checks-actions
Approved by: lqd
Pushing 9b1a30e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 7, 2025
@bors bors merged commit 9b1a30e into rust-lang:master Aug 7, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 61cb1e9 (parent) -> 9b1a30e (this PR)

Test differences

Show 1 test diff

Stage 2

  • [debuginfo-gdb] tests/debuginfo/embedded-visualizer.rs: ignore (ignored when the target environment is musl (linker too old in CI)) -> pass (J0)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 9b1a30e5e69e1537ef6eb6eb829eb47075206dea --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 4831.2s -> 6308.0s (30.6%)
  2. tidy: 130.8s -> 104.3s (-20.2%)
  3. dist-x86_64-apple: 11471.1s -> 9527.9s (-16.9%)
  4. pr-check-2: 2681.2s -> 2227.1s (-16.9%)
  5. x86_64-apple-1: 7029.8s -> 8057.2s (14.6%)
  6. x86_64-gnu-llvm-19: 2837.6s -> 2470.4s (-12.9%)
  7. x86_64-gnu-tools: 3750.6s -> 3312.8s (-11.7%)
  8. x86_64-rust-for-linux: 2876.1s -> 2566.1s (-10.8%)
  9. pr-check-1: 1654.8s -> 1482.8s (-10.4%)
  10. x86_64-msvc-ext2: 6483.7s -> 5836.2s (-10.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@bjorn3 bjorn3 deleted the revert_preserve_debug_gdb_scripts branch August 7, 2025 11:25
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9b1a30e): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.8% [0.6%, 4.8%] 4
Improvements ✅
(primary)		 -48.0% [-60.4%, -35.6%] 2
Improvements ✅
(secondary)		 -0.5% [-0.5%, -0.5%] 3
All ❌✅ (primary) -48.0% [-60.4%, -35.6%] 2

Max RSS (memory usage)

Results (primary -4.5%, secondary -4.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -4.5% [-8.1%, -2.2%] 3
Improvements ✅
(secondary)		 -4.5% [-4.5%, -4.5%] 1
All ❌✅ (primary) -4.5% [-8.1%, -2.2%] 3

Cycles

Results (primary -47.2%, secondary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [2.0%, 3.1%] 4
Improvements ✅
(primary)		 -47.2% [-59.4%, -34.9%] 2
Improvements ✅
(secondary)		 -5.5% [-8.1%, -2.3%] 3
All ❌✅ (primary) -47.2% [-59.4%, -34.9%] 2

Binary size

Results (primary -0.2%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.2% [-0.8%, -0.0%] 46
Improvements ✅
(secondary)		 -0.3% [-1.2%, -0.0%] 86
All ❌✅ (primary) -0.2% [-0.8%, -0.0%] 46

Bootstrap: 464.27s -> 465.481s (0.26%)
Artifact size: 377.42 MiB -> 377.39 MiB (-0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Aug 7, 2025
@Kobzol
Copy link
Member

Kobzol commented Aug 12, 2025

Revert of a PR that caused a massive perf. regression

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lqd lqd

Labels
A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
8 participants
@bjorn3 @rustbot @lqd @bors @Zalathar @rust-timer @Kobzol @jieyouxu